Quoting Jisheng Zhang (2013-08-22 05:46:50)
> Add missing iounmap to setup error path.
>
> Signed-off-by: Jisheng Zhang <jszh...@marvell.com>
Patch looks good with one minor nitpick below.
> @@ -145,10 +147,8 @@ void __init mvebu_clk_gating_setup(struct device_node
> *np,
> ctrl->num_gates = n;
> ctrl->gates = kzalloc(ctrl->num_gates * sizeof(struct clk *),
> GFP_KERNEL);
> - if (WARN_ON(!ctrl->gates)) {
> - kfree(ctrl);
> - return;
> - }
> + if (WARN_ON(!ctrl->gates))
> + goto bail_out;
>
> for (n = 0; n < ctrl->num_gates; n++) {
> const char *parent =
> @@ -160,4 +160,10 @@ void __init mvebu_clk_gating_setup(struct device_node
> *np,
> }
>
> of_clk_add_provider(np, clk_gating_get_src, ctrl);
> +
> + return;
> +bail_out:
> + kfree(ctrl);
> +ctrl_out:
> + iounmap(base);
bail_out is not the best name. How about gates_out?
Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
