On Tuesday 20 August 2013, Stephen Warren wrote: > On 08/20/2013 02:44 PM, Arnd Bergmann wrote: > > On Tuesday 20 August 2013, Stephen Warren wrote:
> Hmm. This probably isn't too hard. I /think/ the only reason the clocks > are initialized early is: > > * The PMC HW block is involved in the path of some interrupts (i.e. it > inverts, or not, the IRQ input pin dedicated to the PMIC). > > * So, that part of the PMC must be initialized early so that the IRQ > polarity is correct. > > * The PMC initialization is currently monolithic, and the PMC has some > clock inputs, so the init routine ends up calling of_clk_get_by_name(), > and hence clocks must be set up early too. > > Perhaps if we just separate tegra_pmc_init() into two functions which > initialize different parts of the PMC, we can get rid of the > tegra_dt_init_irq() -> tegra_pmc_init() -> of_clk_get_by_name() call > path, and hence move Tegra's call to of_clk_init() to the typical place. That sounds good to me, thanks for looking into it. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/