On 21/08/2013 16:53, Eric Dumazet wrote: > On Wed, 2013-08-21 at 13:39 +0300, Eliezer Tamir wrote: > >> >> Instead of remembering the napi_id for all the sockets in an epoll, >> we only track the first socket we see with any unique napi_id. >> The rational for this is that while there may be many thousands of >> sockets tracked by a single epoll, we expect to only see a handful >> of unique napi_ids in most cases. > > This looks buggy assumption to me. > > We use epoll() with in the order of millions of fds per epoller, and > typically one napi_id per cpu. > > With your model, we would have to use nr_cpu epollers and make sure that > sockets are properly placed on those epollers by their napi_ids.
There is no assumption here on how the user configures epoll. All we are doing is reducing the list of sockets monitored by an epoll instance to a smaller subset where each NAPI_ID appears only once. The user is free to have an epoll monitor sockets from queues associated to any CPU. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
