2013/8/20 Marc Dionne <marc.c.dio...@gmail.com>: > On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds > <torva...@linux-foundation.org> wrote: >> On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne <marc.c.dio...@gmail.com> wrote: >>> >>> By my reading that commit (f0c3b5093add) also made proc_readdir always >>> return 0, so with this patch the effect I see is that no pid entries >>> are listed under /proc, breaking ps for instance. I don't see how >>> even the previous version of proc_readdir could return a negative >>> value; looks like 1 and 0 were the only possible return values. >> >> Yes, see the other thread. The "return 1" case had gotten lost. I >> think current git should get everything right, but please do test. I >> did some testing of my own with a random little getdents test-program >> (just checking that it got the same results with different (small) >> buffer sizes), but it was by no means exhaustive. >> >> Linus > > It does fix the symptoms I was seeing, thanks. "ps" now has output > and the pid entries are now visible again under /proc. > > Marc arg ! I was so focused on getting the non-PID proc entries right that I didn't even see all the missing PIDs when I tested it !
/me need holidays. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
