On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > > > acpi_i2c: module license 'unspecified' taints kernel. > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitsel...@oracle.com> > > > > > > Looks good to me. > > > > > > Acked-by: Mika Westerbeg <mika.westerb...@linux.intel.com> > > > > Well, OK, but do we need to be able to build that as a module? > > > > Maybe it should just be yes or no? > > > > Rafael > > > > Perhaps have depends on I2C=y and be a bool instead of tristate?
Yes, that's the idea. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
