At Fri, 16 Aug 2013 11:18:59 -0600,
Tim Gardner wrote:
>
> Direct calls to printk_limit() will emit log noise even when CONFIG_SND_DEBUG
> is not
> defined. Add a wrapper macro around printk_limit() that is conditionally
> defined by
> CONFIG_SND_DEBUG.
>
> Cc: Jaroslav Kysela <[email protected]>
> Cc: Takashi Iwai <[email protected]>
> Cc: Pierre-Louis Bossart <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: Yacine Belkadi <[email protected]>
> Signed-off-by: Tim Gardner <[email protected]>
> ---
>
> checkpatch is moaning about the use of printk_ratelimit(), but
> printk_ratelimited() seems like overkill for a debug feature.
>
> WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to
> printk_ratelimit
> #38: FILE: include/sound/core.h:382:
> +#define snd_printd_ratelimit() printk_ratelimit()
Thanks, applied both patches now.
But it's no real bug, so I postpone this for 3.12 inclusion.
Takashi
>
> include/sound/core.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/sound/core.h b/include/sound/core.h
> index c586617..2a14f1f 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -27,6 +27,7 @@
> #include <linux/rwsem.h> /* struct rw_semaphore */
> #include <linux/pm.h> /* pm_message_t */
> #include <linux/stringify.h>
> +#include <linux/printk.h>
>
> /* number of supported soundcards */
> #ifdef CONFIG_SND_DYNAMIC_MINORS
> @@ -376,6 +377,11 @@ void __snd_printk(unsigned int level, const char *file,
> int line,
> #define snd_BUG() WARN(1, "BUG?\n")
>
> /**
> + * Suppress high rates of output when CONFIG_SND_DEBUG is enabled.
> + */
> +#define snd_printd_ratelimit() printk_ratelimit()
> +
> +/**
> * snd_BUG_ON - debugging check macro
> * @cond: condition to evaluate
> *
> @@ -398,6 +404,8 @@ static inline void _snd_printd(int level, const char
> *format, ...) {}
> unlikely(__ret_warn_on); \
> })
>
> +static inline bool snd_printd_ratelimit(void) { return false; }
> +
> #endif /* CONFIG_SND_DEBUG */
>
> #ifdef CONFIG_SND_DEBUG_VERBOSE
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
