On Sat, 2013-08-17 at 17:44 +0200, Borislav Petkov wrote:
> On Sat, Aug 17, 2013 at 02:03:51AM -0700, Joe Perches wrote:
> > checkpatch tends to be used for firs patch submissions and
> > adding it would only encourage a new wave of trivial whitespace
> > patches.
>
> Nope, we definitely don't want that...
>
> > I think there are already way, _way_ too many existing instances
> > of comments that are of the form
> > /* foo
> > * ...
> > to add that.
> >
> > There are 10s of thousands outside of net/ and drivers/net/.
>
> ... unless there's a way to detect new submissions and scream only
> for those. I.e., look at lines starting with "+" which don't have
> corresponding "-" lines.
No, that's not the right way to do that.
That bit's relatively easy because checkpatch only looks
at files when there's a specific command line -f flag.
So just check the existence of the -f command line flag
(!$file) and for an added comment that starts "/* foo" without
a comment termination */ after it on the same line.
> This would need a bit of experimenting and is not trivial though, maybe
> Algorithm::Diff could even help there.
>
> Sounds like a mini-project for a perl dude :-)
I'm not one of those...
This might work though
scripts/checkpatch.pl | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9ba4fc4..abe820a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2119,6 +2119,15 @@ sub process {
}
}
+ if (!$file &&
+ $realfile !~ m@^(drivers/net/|net/)@ &&
+ $rawline =~ /^\+/ && #Added line
+ $rawline !~ m@/\*.*\*/@ && #whole comments
+ $rawline =~ m@/\*+.+@) { #unterminated comment
+ WARN("COMMENT_STYLE",
+ "block comments use an empty /* line\n" .
$herecurr);
+ }
+
if ($realfile =~ m@^(drivers/net/|net/)@ &&
$prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
$rawline =~ /^\+[ \t]*\*/) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
