On Tue, Aug 06, 2013 at 05:36:43PM +0900, Joonsoo Kim wrote:
> - if (sds->group_imb) {
> - sds->busiest_load_per_task =
> - min(sds->busiest_load_per_task, sds->avg_load);
> + if (busiest->group_imb) {
> + busiest->load_per_task =
> + min(busiest->load_per_task, sds->sd_avg_load);
> }
> - if (sds->max_load < sds->avg_load) {
> + if (busiest->avg_load < this->avg_load) {
Tsk, inconsistency there.
> - max_pull = min(sds->max_load - sds->avg_load, load_above_capacity);
> + max_pull = min(busiest->avg_load - sds->sd_avg_load,
> + load_above_capacity);
you just made it possible for the above subtraction to become negative.
Also not entirely sure why you renamed sds->avg_load; renaming it back.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
