On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt <rost...@goodmis.org> wrote: > On Tue, 13 Aug 2013 20:34:58 -0300 > Lucas De Marchi <lucas.de.mar...@gmail.com> wrote: > > >> so in kcmdline we would have modulename.param instead of modulename.param=1? >> >> I guess we need to update kmod then, because currently we ignore and >> treat this case as a wrong token. From a quick look, allowing it in >> kmod would be as simple as removing a condition check. >> >> Lucas De Marchi > > Note, both will still work. And it didn't change much. Today, anything > that uses "module_param()" with bool type (a quick git grep shows 570 > users), already do not require a value. > > Randomly looking at one... drivers/input/mouse/synaptics_i2c.c, you can > just do: > > insmod synaptics_i2c.ko no_filter > > no need to add a "=1" to that. > > But anything else will still require a value. I just want to allow > other parameters that act like a boolean to not require one.
true... but currently "modprobe synaptics_i2c" doesn't get the parameter correctly from kernel command line if it doesn't have a value. And I agree this not something that changed but rather a bug in kmod waiting to be fixed. Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
