On Thu, 1 Aug 2013 20:39:02 +0200 Alexander Holler <hol...@ahsoftware.de>
wrote:
> Enable the processing of HID input records before the RTC will be registered,
> in order to allow the RTC register function to read clock. Without doing
> that the clock can only be read after the probe function has finished.
>
> Signed-off-by: Alexander Holler <hol...@ahsoftware.de>
> ---
> drivers/rtc/rtc-hid-sensor-time.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/rtc/rtc-hid-sensor-time.c
> b/drivers/rtc/rtc-hid-sensor-time.c
> index 1ab3d13..1006a62 100644
> --- a/drivers/rtc/rtc-hid-sensor-time.c
> +++ b/drivers/rtc/rtc-hid-sensor-time.c
> @@ -279,11 +279,18 @@ static int hid_time_probe(struct platform_device *pdev)
> return ret;
> }
>
> + /*
> + * Enable HID input processing early in order to be able to read the
> + * clock already in devm_rtc_device_register().
> + */
> + hid_device_io_start(hsdev->hdev);
> +
> time_state->rtc = devm_rtc_device_register(&pdev->dev,
> "hid-sensor-time", &hid_time_rtc_ops,
> THIS_MODULE);
>
> if (IS_ERR_OR_NULL(time_state->rtc)) {
> + hid_device_io_stop(hsdev->hdev);
> ret = time_state->rtc ? PTR_ERR(time_state->rtc) : -ENODEV;
> time_state->rtc = NULL;
> sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TIME);
Shouldn't now there be a hid_device_io_stop() in hid_time_remove()?
Also, hid_device_io_start() does a weird up() on a
downed-by-someone-else semaphore. Where was that down() performed in
this case?
Also, your changelog implies that the kernel is already doing this
hid_device_io_start(), only it does it too late. If that is the case
then will the existing-before-this-patch call to hid_device_io_start()
generate the "io already started" warning?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
