On Tue, 2013-08-06 at 17:01 +0000, Christoph Lameter wrote:
> Reduces overhead a bit and frees up a couple of registers.
>
> Signed-off-by: Christoph Lameter <c...@linux.com>
>
> Index: linux/arch/x86/include/asm/debugreg.h
> ===================================================================
> --- linux.orig/arch/x86/include/asm/debugreg.h 2013-07-30
> 14:00:30.000000000 -0500
> +++ linux/arch/x86/include/asm/debugreg.h 2013-07-30 14:00:57.503076270
> -0500
> @@ -97,11 +97,11 @@ extern void hw_breakpoint_restore(void);
> DECLARE_PER_CPU(int, debug_stack_usage);
> static inline void debug_stack_usage_inc(void)
> {
> - __get_cpu_var(debug_stack_usage)++;
> + __this_cpu_inc(debug_stack_usage);
I don't remember why I didn't use this in the first place. Perhaps I was
still in the "get_cpu" mind set.
Also, what's the difference between "__this_cpu_inc()" and
"this_cpu_inc()"?
> }
> static inline void debug_stack_usage_dec(void)
> {
> - __get_cpu_var(debug_stack_usage)--;
> + __this_cpu_dec(debug_stack_usage);
> }
> int is_debug_stack(unsigned long addr);
> void debug_stack_set_zero(void);
Might as well change is_debug_stack() to use __this_cpu_read() instead
of __get_cpu_var().
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
