On Fri, 02 Aug, at 02:29:05PM, Roy Franz wrote:
> The x86/AMD64 EFI stubs must us a call wrapper to convert between
> the Linux and EFI ABIs, so void pointers are sufficient.  For ARM,
> the ABIs are compatible, so we can directly invoke the function
> pointers.  The functions that are used by the ARM stub are updated
> to match the EFI definitions.
> 
> Signed-off-by: Roy Franz <roy.fr...@linaro.org>
> ---
>  include/linux/efi.h |   61 
> +++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 44 insertions(+), 17 deletions(-)

[...]

> @@ -96,6 +98,26 @@ typedef    struct {
>  #define EFI_MEMORY_DESCRIPTOR_VERSION        1
>  
>  #define EFI_PAGE_SHIFT               12
> +#define EFI_PAGE_SIZE                (1UL << EFI_PAGE_SHIFT)
> +
> +typedef enum {
> +     EfiReservedMemoryType,
> +     EfiLoaderCode,
> +     EfiLoaderData,
> +     EfiBootServicesCode,
> +     EfiBootServicesData,
> +     EfiRuntimeServicesCode,
> +     EfiRuntimeServicesData,
> +     EfiConventionalMemory,
> +     EfiUnusableMemory,
> +     EfiACPIReclaimMemory,
> +     EfiACPIMemoryNVS,
> +     EfiMemoryMappedIO,
> +     EfiMemoryMappedIOPortSpace,
> +     EfiPalCode,
> +     EfiMaxMemoryType
> +} EFI_MEMORY_TYPE;
> +

These enums aren't used anywhere in your patches from what I can see and
we already have #define's for all these values, e.g. EFI_RESERVED_TYPE.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to