Hi Andi,
On Fri, 2 Aug 2013 17:41:10 -0700, Andi Kleen wrote:
> From: Andi Kleen <a...@linux.intel.com>
>
> Add support for enabling already set up counters by using an
> ioctl. I share some code with the filter setup.
>
> Signed-off-by: Andi Kleen <a...@linux.intel.com>
> ---
> tools/perf/util/evsel.c | 21 ++++++++++++++++++---
> tools/perf/util/evsel.h | 1 +
> 2 files changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index c9c7494..60e0d84 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -605,16 +605,16 @@ int perf_evsel__alloc_fd(struct perf_evsel *evsel, int
> ncpus, int nthreads)
> return evsel->fd != NULL ? 0 : -ENOMEM;
> }
>
> -int perf_evsel__set_filter(struct perf_evsel *evsel, int ncpus, int nthreads,
> - const char *filter)
> +static int perf_evsel__run_ioctl(struct perf_evsel *evsel, int ncpus, int
> nthreads,
> + int ioc, void *arg)
> {
> int cpu, thread;
>
> for (cpu = 0; cpu < ncpus; cpu++) {
> for (thread = 0; thread < nthreads; thread++) {
> int fd = FD(evsel, cpu, thread),
> - err = ioctl(fd, PERF_EVENT_IOC_SET_FILTER, filter);
>
> + err = ioctl(fd, ioc, arg);
Looks very strange to have a blank line between variable declarations.
You'd better separating declarations on the other lines like:
int fd, err;
fd = FD(evsel, cpu, thread);
err = ioctl(fd, ioc, arg);
Thanks,
Namhyung
> if (err)
> return err;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
