On Wed, Jul 31, 2013 at 08:18:32AM +0200, Jean-Francois Moine wrote: > The kirkwood audio driver is used without DT in the Kirkwood machine. > This patch adds a DT compatible definition for use in other Marvell > machines such as the Armada 88AP510 (Dove). > > Signed-off-by: Jean-Francois Moine <moin...@free.fr> > --- > sound/soc/kirkwood/kirkwood-i2s.c | 27 ++++++++++++++++------ > 1 file changed, 20 insertions(+), 7 deletions(-)
This misses documentation for the DT conversion. Documentation should be created at the same time as a driver is converted. I think you should combine patches 3 and 4 together given that you add the documentation and change the DT compatible name you've given this driver in this patch in patch 4. > > diff --git a/sound/soc/kirkwood/kirkwood-i2s.c > b/sound/soc/kirkwood/kirkwood-i2s.c > index a13fffb..234b5a1 100644 > --- a/sound/soc/kirkwood/kirkwood-i2s.c > +++ b/sound/soc/kirkwood/kirkwood-i2s.c > @@ -12,7 +12,6 @@ > > #include <linux/init.h> > #include <linux/module.h> > -#include <linux/platform_device.h> Why are you getting rid of this include? It still makes use of platform devices and the like, so it _should_ continue to include this. Don't rely on implicit includes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
