On Mon, Jul 29, 2013 at 11:35:23AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Jul 29, 2013 at 08:52:59PM +0800, Shaohua Li wrote: > > Ah, ok, I thought it's straightforward... It's a bug fix. > > It never is, seriously. If it's something trivial / straighforward, > please say so in the patch description because not doing so forces > other people to guess the intention behind the change which sucks and > this isn't even that trivial. > > > echo '0' > /sys/bus/workqueue/devices/xxx/numa > > cat /sys/bus/workqueue/devices/xxx/numa > > I got 1. It should be 0, the reason is copy_workqueue_attrs() called in > > apply_workqueue_attrs() doesn't copy no_numa field. > > Note that copy_workqueue_attrs() is also used while creating worker > pools and this change would mean that there will be worker pools with > no_numa attribute assigned basically randomly depending on which wq > created the pool for the first time which should be fine AFAICS but > isn't very nice. Given that there's only single place where a pool's > attrs is set, maybe it'd be best to clear no_numa right after copy and > explain what's going on there?
alloc_workqueue_attrs() always zero the new allocated attr. Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
