At Fri, 26 Jul 2013 12:02:51 -0700, Felipe Tonello wrote: > > Hi Mark, > > On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown <broo...@kernel.org> wrote: > > On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote: > >> From: "Felipe F. Tonello" <e...@felipetonello.com> > >> > >> ALSA standard jacks already are implemented using ALSA KControl. > >> So there is no need implement that itself or to use snd_jack > >> for input events only. > > > > Similar changlog comment as on the ASoC patch and... > > Ok. > > > > >> snd_jack_new(chip->card, "Headphone", > >> - SND_JACK_HEADPHONE, &data->hp_jack); > >> + SND_JACK_HEADPHONE, 0, &data->hp_jack); > >> xonar_ds_handle_hp_jack(chip); > > > > ...this really ought to be done as part of the commit that adds the > > parameter since it breaks the build until this patch is applied. > > But that's why is a patch series. But as you say, are you suggesting > me to propose this changes in one patch only?
The basic rule of the patch series is: - they are split in a logical manner - each commit must not break the build The second rule is important especially for bisection and backporting. You could have done in a different way (e.g. adding a new function like snd_jack_new_with_index() instead of changing snd_jack_new() itself). Which way is better, depends on the implementation details. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
