On Thu, Jul 25, 2013 at 03:34:25PM +0100, James Hogan wrote: > TREE_RCU and TREE_PREEMPT_RCU both cause kernel/rcutree.c to be built, > but only TREE_RCU selects IRQ_WORK, which can result in an undefined > reference to irq_work_queue for some (random) configs: > > kernel/built-in.o In function `rcu_start_gp_advanced': > kernel/rcutree.c:1564: undefined reference to `irq_work_queue' > > Select IRQ_WORK from TREE_PREEMPT_RCU too to fix this.
Queued for 3.12, good catch, James! Thanx, Paul > Signed-off-by: James Hogan <james.ho...@imgtec.com> > Cc: Steven Rostedt <rost...@goodmis.org> > Cc: Paul E. McKenney <paul...@linux.vnet.ibm.com> > Cc: Dipankar Sarma <dipan...@in.ibm.com> > --- > init/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/init/Kconfig b/init/Kconfig > index 247084b..c08a549 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -470,6 +470,7 @@ config TREE_RCU > config TREE_PREEMPT_RCU > bool "Preemptible tree-based hierarchical RCU" > depends on PREEMPT > + select IRQ_WORK > help > This option selects the RCU implementation that is > designed for very large SMP systems with hundreds or > -- > 1.8.1.2 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/