On 07/25/2013 07:26 AM, Gianluca Anzolin wrote:
> The function tty_port_tty_hangup() could leak a reference to the tty_struct:
>
> struct tty_struct *tty = tty_port_tty_get(port);
>
> if (tty && (!check_clocal || !C_CLOCAL(tty))) {
> tty_hangup(tty);
> tty_kref_put(tty);
> }
>
> If tty != NULL and the second condition is false we never call tty_kref_put
> and
> the reference is leaked.
>
> Fix by always calling tty_kref_put() which accepts a NULL argument.
>
> The patch fixes a regression introduced by commit aa27a094.
>
> Acked-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
> Signed-off-by: Gianluca Anzolin <gianl...@sottospazio.it>
Acked-by: Jiri Slaby <jsl...@suse.cz>
Thanks for the fix.
> ---
> drivers/tty/tty_port.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
> index 121aeb9..f597e88 100644
> --- a/drivers/tty/tty_port.c
> +++ b/drivers/tty/tty_port.c
> @@ -256,10 +256,9 @@ void tty_port_tty_hangup(struct tty_port *port, bool
> check_clocal)
> {
> struct tty_struct *tty = tty_port_tty_get(port);
>
> - if (tty && (!check_clocal || !C_CLOCAL(tty))) {
> + if (tty && (!check_clocal || !C_CLOCAL(tty)))
> tty_hangup(tty);
> - tty_kref_put(tty);
> - }
> + tty_kref_put(tty);
> }
> EXPORT_SYMBOL_GPL(tty_port_tty_hangup);
>
>
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
