On Tue, Jul 23, 2013 at 9:47 PM, Peter Zijlstra <pet...@infradead.org> wrote: > On Tue, Jul 23, 2013 at 09:44:17PM +0600, Rakib Mullick wrote: >> Currently, update_top_cache_domain() is called whenever schedule domain is >> built or destroyed. But, the following >> callpath shows that they're at the same callpath and can be avoided >> update_top_cache_domain() while destroying schedule >> domain and update only at the times of building schedule domains. >> >> partition_sched_domains() >> detach_destroy_domain() >> cpu_attach_domain() >> update_top_cache_domain() >> build_sched_domains() >> cpu_attach_domain() >> update_top_cache_domain() >> > > Does it really matter?
Why should we do it twice? More importantly at the time of destroying even though we know it'll be built again just few moment later. > > > This just makes the code uglier for no gain afaict. > > If you really need to do this, key off @sd == NULL or something. Sorry, would you please a bit more clearer? I can't pick what you're suggesting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
