On 07/23/2013 10:53 AM, Russell King - ARM Linux wrote: > On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote: >> The kirkwood i2s driver is used without DT in the Kirkwood machine. >> This patch adds a DT compatible definition for use in other Marvell >> machines as the Armada 88AP510 (Dove). > > Yet again, this illustrates why converting to DT causes backwards > steps in drivers: the conversion of devm_clk_get() to of_clk_get() > necessitates a clk_put().
That's just a very poor usage of the API in this patch. devm_clk_get() works fine on DT and non-DT platforms. The driver shouldn't need any changes in that regard. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
