On 07/21/2013 10:12 PM, Laxman Dewangan wrote:
> Add of_device_id table for Palma GPIO to be enable the
> driver from DT file.
>
> The driver can be registered from DT file as:
> palmas: tps65913@58 {
> :::::::::::
> palmas_gpio: palmas_gpio {
> compatible = "ti,palmas-gpio";
> gpio-controller;
> #gpio-cells = <2>;
> };
> };
>
> Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt
> b/Documentation/devicetree/bindings/gpio/gpio-palmas.txt
> +- #gpio-cells : Should be two.
> + - first cell is the gpio pin number
> + - second cell is used to specify optional parameters (unused)
Shouldn't the second cell contain the standard GPIO-related flags such
as bit 0 == active-low?
Aside from that, this binding and indeed the rest of the patch looks
fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
