Hi,

2013-07-19 (금), 16:18 +0800, Gu Zheng:
> After writing orphan inode entry in jornal block, we need to delete each
> entry from the orphan entry list, and release them.
> 
> 
> Signed-off-by: Gu Zheng <guz.f...@cn.fujitsu.com>
> ---
>  fs/f2fs/checkpoint.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 66a6b85..290db04 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info 
> *sbi, block_t start_blk)
>               memset(orphan_blk, 0, sizeof(*orphan_blk));
>  page_exist:
>               orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
> +
> +             list_del(&orphan->list);
> +             kmem_cache_free(orphan_entry_slab, orphan);
> +             sbi->n_orphans--;

NAK.
We should not release them here.
Only f2fs_evict_inode can do it. 

>       }
>       if (!page)
>               goto end;

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to