Hi Linus,
Thanks for both of GPIO patch reviews.
I'll fix them.
> I forgot one thing:
>
> On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo <milo....@ti.com> wrote:
>
> > +static int lp3943_gpio_probe(struct platform_device *pdev)
> > +{
> > + struct lp3943 *l = dev_get_drvdata(pdev->dev.parent);
> > + struct lp3943_gpio *lg;
> > + int ret;
>
> This is where I want you to assign to a member of struct
> lp3943 another u16 mask which tells which lines are
> actually available for GPIO, and you should also add code to
> make sure that lines that are not available fail gpio_request().
>
> This configuration can probably be read out from the device
> tree if you add the compatible node to the MFD cell when
> registering it.
>
> Yours,
> Linus Walleij
Regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
