On Sun, Jul 14, 2013 at 01:29:48PM +0200, Paul Bolle wrote: > Commit ac4c1a9b33 ("staging: drm/imx: Add LDB support") added the > DRM_IMX_LDB Kconfig entry. That entry selects OF_VIDEOMODE. But there is > no Kconfig symbol named OF_VIDEOMODE. The select statement for that > symbol is a nop. Drop it. > > Signed-off-by: Paul Bolle <pebo...@tiscali.nl> > --- > 0) Not tested! > > 1) Perhaps OF_VIDEOMODE was selected because this commit added an > include of <video/of_videomode>. But the functionality of that header > requires the Kconfig symbol VIDEOMODE_HELPERS. The commit didn't use > that Kconfig symbol. > > The again, as far as I can tell, the drm/imx code doesn't actually use > the videomode of-helper. So it seems the include of <video/of_videomode> > isn't needed anyway.
Looks all good. Acked-by: Sascha Hauer <s.ha...@pengutronix.de> Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/