On Mon, Jul 15, 2013 at 10:36:44AM +0200, Jean-Francois Moine wrote: > In the function kirkwood_set_rate, when the rate cannot be satisfied > by the internal nor by an external clock, the clock source in undefined:
> warning: ‘clks_ctrl’ may be used uninitialized in this function
> As the ALSA subsystem should never gives such a rate, this patch removes
> the check of the external clock pointer.
> - } else if (!IS_ERR(priv->extclk)) {
> + } else {
I'd really like to see an analysis explaining why this can never happen,
the driver explicitly supports running without extclk being provided.
Simply asserting that we should never get such a rate isn't really
enough detail...
signature.asc
Description: Digital signature
