That was the busted patch. See the v2 I sent. Only 64-bit needs alignment. And after looking more at it, the idt in head_64.S could be entirely dropped in favor of using the one in arch/x86/kernel/traps.c (after moving it out of the #ifdef.
-Kees On Fri, Jul 12, 2013 at 3:28 PM, H. Peter Anvin <h...@zytor.com> wrote: > On 07/12/2013 11:30 AM, Kees Cook wrote: >> >> - .word 0 # 32-bit align idt_desc.address >> + .word PAGE_SIZE # page align idt_desc.address >> > > ... and this is totally confused. This didn't change alignment one > iota, it only put the value 4096 into the padding. > > -hpa > -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
