Hello.

On 07/12/2013 05:43 PM, Guennadi Liakhovetski wrote:

Similar to the non-DT case, this patch passes SoC-specific configuration
to the driver via device ID matching, instead of platform data.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+rene...@gmail.com>
[...]

diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index a6d53fa..b095d74 100644
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
[...]
@@ -665,6 +666,14 @@ static const struct shdma_ops sh_dmae_shdma_ops = {
        .get_partial = sh_dmae_get_partial,
  };

+static const struct of_device_id sh_dmae_of_match[] = {
+       {.compatible = "renesas,shdma",},
+       {.compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid,},
+       {.compatible = "renesas,shdma-r8a7740", .data = r8a7740_shdma_devid,},

Previously used style assumed spaced after { and before }. Indeed, that would be more consistent with the following line.

+       { }
+};
+MODULE_DEVICE_TABLE(of, sh_dmae_of_match);
+
  static int sh_dmae_probe(struct platform_device *pdev)
  {
        struct sh_dmae_pdata *pdata;
[...]
@@ -915,12 +928,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
        return 0;
  }

-static const struct of_device_id sh_dmae_of_match[] = {
-       { .compatible = "renesas,shdma", },
-       { }
-};
-MODULE_DEVICE_TABLE(of, sh_dmae_of_match);
-

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to