On Wed, Jul 10, 2013 at 06:50:18PM +0900, HATAYAMA Daisuke wrote: [..] > If you want to avoid looking up vmcore_list that takes linear time w.r.t. the > number > of the elements, you can still calculate the range of offsets in /proc/vmcore > corresponding to HSA during /proc/vmcore initialization. > > Also, could you tell me how often and how much the HSA region is during crash > dumping? > I guess the read to HSA is done mainly during early part of crash dumping > process only. > According to the code, it appears at most 64MiB only. Then, I feel > performance is not > a big issue. > > Also, cost of WARN_ONCE() is one memory access only in the 2nd and later > calls. I don't > think it too much overhead...
Hi Hatayama, I think michael's proposal of just putting in WARN_ONCE for non s390 arch sounds reasonable. It is simple and meets your need of being able to detect that non s390 arch don't make use of mmap() path yet. Introducing in_valid_fault_range() kind of sounds overkill to me for this issue. Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
