Re: [PATCH V2 2/4] extcon: palmas: enable ID_GND and ID_FLOAT detection always

[Laxman Dewangan]

On Wednesday 10 July 2013 12:32 PM, Chanwoo Choi wrote:

Hi Laxman,

@@ -84,28 +86,23 @@ static irqreturn_t palmas_id_irq_handler(int irq, void 
*_palmas_usb)

if (set & PALMAS_USB_ID_INT_SRC_ID_GND) {

                palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
-                       PALMAS_USB_ID_INT_EN_HI_SET,
-                       PALMAS_USB_ID_INT_EN_HI_SET_ID_FLOAT);
-               palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
-                       PALMAS_USB_ID_INT_EN_HI_CLR,
-                       PALMAS_USB_ID_INT_EN_HI_CLR_ID_GND);
-               palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
                        PALMAS_USB_ID_INT_LATCH_CLR,
                        PALMAS_USB_ID_INT_EN_HI_CLR_ID_GND);
                palmas_usb->linkstat = PALMAS_USB_STATE_ID;
                extcon_set_cable_state(&palmas_usb->edev, "USB-HOST", true);
+               dev_info(palmas_usb->dev, "HOST cable is attached\n");
        } else if (set & PALMAS_USB_ID_INT_SRC_ID_FLOAT) {
                palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
-                       PALMAS_USB_ID_INT_EN_HI_SET,
-                       PALMAS_USB_ID_INT_EN_HI_SET_ID_GND);
-               palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
-                       PALMAS_USB_ID_INT_EN_HI_CLR,
-                       PALMAS_USB_ID_INT_EN_HI_CLR_ID_FLOAT);
-               palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
                        PALMAS_USB_ID_INT_LATCH_CLR,
                        PALMAS_USB_ID_INT_EN_HI_CLR_ID_FLOAT);
                palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;
                extcon_set_cable_state(&palmas_usb->edev, "USB-HOST", false);
+               dev_info(palmas_usb->dev, "HOST cable is detached\n");
+       } else if ((palmas_usb->linkstat == PALMAS_USB_STATE_ID) &&
+                               (!(set & PALMAS_USB_ID_INT_SRC_ID_GND))) {
+               palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;
+               extcon_set_cable_state(&palmas_usb->edev, "USB-HOST", false);
+               dev_info(palmas_usb->dev, "HOST cable is detached\n");
        }

After I modify info message when USB-HOST cable is attached or detached
as following mesesage, I applied this patch.

"HOST cable is ..." -> "USB-HOST cable is"

Thank you very much for correction and more meaningful message.

Thanks,
Laxman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/