On 10/07/2013 07:41, David Miller wrote: > From: Eliezer Tamir <eliezer.ta...@linux.intel.com> > Date: Wed, 10 Jul 2013 06:29:16 +0300 > >> If the following names changes are acceptable I will try to send out >> a patch today.
>> 2. ndo_ll_poll -> ndo_busy_poll >> >> - not technically accurate since the ndo callback does not itself busy >> poll, it's just used to implement it. > > I think this name change is accurate, it expresses the two elements of > what it does. It's busy waiting, in that it's doing a synchronous > scan of the device's RX queue, and it's polling just like NAPI polling > does. OK > Well... what would be great would be to come up with some single > interface that drivers can implement rather than having to have > both napi->poll and netdevice_ops->ndo_ll_poll(). But that's a task > for a later date. > > Therefore, ndo_busy_poll is probably best for now. I will think about this, maybe we could even unify ndo_poll_controller. It seems like said unified method would have to have an extra parameter that would indicate from which context it was called: 1. from napi poll (bh) 2. from poll controller (with interrupts disabled) 3. from busy poll (user context) -of course not for today. > Nope, looks complete. And also do the manpage update. Where do I find the repository for the manpages? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
