On Mon, Jul 1, 2013 at 2:03 AM, Ingo Molnar <mi...@kernel.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> perf-core-for-linus
>
> Kernel improvements:
>
> * AMD IOMMU uncore PMU support by Suravee Suthikulpanit001a
This one prints a really annoying error message if you're not on an
AMD platform:
+ if (!amd_iommu_pc_supported()) {
+ pr_err("perf: amd_iommu PMU not installed. No support!\n");
+ return -ENODEV;
+ }
and you know what? That's not acceptable. It damn well is *not* an
error to not have an AMD IOMMU.
It should - at most - be a pr_info(). Maybe nothing at all. "pr_err()"
is just totally out of line.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
