On Tue, Jul 02, 2013 at 11:39:28, Nori, Sekhar wrote:
> On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote:
> > On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote:
> >> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote:
> >>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN)
> >>> is available to enable Alarm Wakeup feature. This register needs to be
> >>> properly handled for the rtcwake to work properly.
> >>>
> >>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt
> >>> compatibility node.
> >>>
> >>> Signed-off-by: Hebbar Gururaja <gururaja.heb...@ti.com>
> >>> Cc: Grant Likely <grant.lik...@linaro.org>
> >>> Cc: Rob Herring <rob.herr...@calxeda.com>
> >>> Cc: Rob Landley <r...@landley.net>
> >>> Cc: Sekhar Nori <nsek...@ti.com>
> >>> Cc: Kevin Hilman <khil...@linaro.org>
> >>> Cc: Alessandro Zummo <a.zu...@towertech.it>
> >>> Cc: rtc-li...@googlegroups.com
> >>> Cc: devicetree-disc...@lists.ozlabs.org
> >>> Cc: linux-...@vger.kernel.org
> >>> ---
> >>
> >> [...]
> >>
> >>> -#define OMAP_RTC_DATA_DA830_IDX 1
> >>> +#define OMAP_RTC_DATA_DA830_IDX 1
> >>> +#define OMAP_RTC_DATA_AM335X_IDX 2
> >>>
> >>> static struct platform_device_id omap_rtc_devtype[] = {
> >>> {
> >>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] =
> >>> {
> >>> }, {
> >>> .name = "da830-rtc",
> >>> .driver_data = OMAP_RTC_HAS_KICKER,
> >>> + }, {
> >>> + .name = "am335x-rtc",
> >>
> >> may be use am3352-rtc here just to keep the platform device name and of
> >> compatible in sync.
> >
> > Correct. I will update the same in v2.
> >
> >>
> >>> + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN,
> >>> },
> >>> {},
> >>
> >> It is better to use the index defined above in the static initialization
> >> so they remain in sync.
> >
> > Sorry. I didn’t get this.
> >
>
> See example below I provided. If its still not clear, let me know what
> is not clear.
>
> >> ...
> >> [OMAP_RTC_DATA_DA830_IDX] = {
> >> .name = "da830-rtc",
> >> .driver_data = OMAP_RTC_HAS_KICKER,
> >> },
Thanks for the clarification. In this case will it ok if I update the previous
member also.
>
> Thanks,
> Sekhar
>
Regards,
Gururaja
