On Thu, Jun 27, 2013 at 04:54:58PM +0200, Peter Zijlstra wrote:
> On Wed, Jun 26, 2013 at 03:38:05PM +0100, Mel Gorman wrote:
> > +static int
> > +find_idlest_cpu_node(int this_cpu, int nid)
> > +{
> > + unsigned long load, min_load = ULONG_MAX;
> > + int i, idlest_cpu = this_cpu;
> > +
> > + BUG_ON(cpu_to_node(this_cpu) == nid);
> > +
> > + for_each_cpu(i, cpumask_of_node(nid)) {
> > + load = weighted_cpuload(i);
> > +
> > + if (load < min_load) {
> > + struct task_struct *p;
> > +
> > + /* Do not preempt a task running on its preferred node
> > */
> > + struct rq *rq = cpu_rq(i);
> > + local_irq_disable();
> > + raw_spin_lock(&rq->lock);
>
> raw_spin_lock_irq() ?
>
/me slaps self
Fixed. Thanks.
> > + p = rq->curr;
> > + if (p->numa_preferred_nid != nid) {
> > + min_load = load;
> > + idlest_cpu = i;
> > + }
> > + raw_spin_unlock(&rq->lock);
> > + local_irq_disable();
> > + }
> > + }
> > +
> > + return idlest_cpu;
> > +}
--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
