On Thu, Jun 27, 2013 at 12:54:35PM +0200, Borislav Petkov wrote: > On Thu, Jun 27, 2013 at 12:26:40AM +0800, Wang YanQing wrote: > > > > We should set X86 to 486 before use cpuid > > to detect the cpu type, if we set X86 to 486 > > after cpuid, then we will get 486 for ever. > > So not "for ever" but until cpu_detect runs. > > > > > Yes, we will correct this in early_cpu_init, > > but it is still a wrong behavior, right? So > > just fix it. > > Right, so this patch is correct and it fixes the small window where we > run with family == 4 before cpu_detect but the commit message needs a > bit massaging before it gets applied.
I think it fixes the window where we run with family > 4 before cpu_detect :) > > > > > I also find maybe we can delete the new_cpu_data, > > because we will over write all the information > > in early_cpu_init, and before early_cpu_init, > > there is no user of new_cpu_data, but this is > > another patch in the future. > > You can drop that part. I can't catch the exactly meaning: We can drop the new_cpu_data or I need to drop this part commit message. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
