On 14.06.13 11:36:00, Namhyung Kim wrote:
> > +static int pers_event_sysfs_register(struct pers_event *event)
> > +{
> > + struct device_attribute *attr = &event->sysfs.attr;
> > + int idx;
> > +
> > + *attr = (struct device_attribute)__ATTR(, 0444, pers_event_sysfs_show,
> > + NULL);
> > + attr->attr.name = event->name;
>
> When I added another persistent event with this API, I got an WARNING
> from lockdep like this:
>
> [ 0.432506] BUG: key ffff88040946f140 not in .data!
> [ 0.432581] ------------[ cut here ]------------
> [ 0.432656] WARNING: at /home/namhyung/project/linux/kernel/lockdep.c:2987
> lockdep_init_map+0x53d/0x570()
> [ 0.432763] DEBUG_LOCKS_WARN_ON(1)
>
>
> I guess we need the following line here:
>
> sysfs_attr_init(&attr->attr);
Yes, added your change. Thanks Namhyung for reviewing and testing.
-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
