On Wed, Jun 12, 2013 at 09:59:18PM +0200, Thierry Reding wrote: > On Wed, Jun 12, 2013 at 05:05:18PM +0530, Sachin Kamat wrote: > > Hi Thierry, > > > > On 12 June 2013 16:59, Thierry Reding <thierry.red...@gmail.com> wrote: > > > Some drivers don't set the .owner fields of the struct device_driver or > > > struct pwm_ops, which causes the module usage count to become wrong. > > > > > > Recently a patch [1] was added to solve this issue of missing .owner > > fileds in struct platform_driver. > > Yes I saw that, but thought it might be good to initialize them anyway. > Especially since a couple of the drivers are I2C and I believe there's > no similar patch for those. It shouldn't be difficult to come up with > the corresponding patch, though. > > I wonder if it'd make sense to remove all the explicit assignments of > .owner = THIS_MODULE in platform drivers once the patch you mentioned > has been merged. Cc'ing Greg to find out what he thinks about it.
Sure, they can be removed, but it's not really a big deal if they aren't. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
