Dear Gregory CLEMENT,
On Fri, 7 Jun 2013 17:42:22 +0200, Gregory CLEMENT wrote:
> /* Driver states */
> enum {
> MV64XXX_I2C_STATE_INVALID,
> @@ -110,6 +133,7 @@ struct mv64xxx_i2c_data {
> spinlock_t lock;
> struct i2c_msg *msg;
> struct i2c_adapter adapter;
> + int bridge_enabled;
bool ?
> @@ -528,6 +652,7 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data,
> {
> u32 bus_freq, tclk;
> int rc = 0;
> + const char *bridge_status;
>
> /* CLK is mandatory when using DT to describe the i2c bus. We
> * need to know tclk in order to calculate bus clock
> @@ -554,6 +679,15 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data,
> * So hard code the value to 1 second.
> */
> drv_data->adapter.timeout = HZ;
> +
> + /*
> + * Acquire information on Transaction Generator support.
> + */
> + bridge_status = of_get_property(np, "", NULL);
It is not clear to me what this new bridge_status local variable is
doing.
> + if (of_property_read_bool(np, "i2c,i2c-bridge"))
> + drv_data->bridge_enabled = 1;
> + else
> + drv_data->bridge_enabled = 0;
This could be written directly as:
drv_data->bridge_enabled = of_property_read_bool(np, "i2c,i2c-bridge");
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
