On Wed, 2013-06-05 at 18:02 +0100, Stefano Stabellini wrote: > Changes in v4: > - build the entire arch/arm/xen directory under arch/arm64, ifdef > hypercall.S appropriately.
This is probably the best (or equal first) of a bunch of bad options :-/ > + * The Xen hypercall calling convention is very similar to the ARM/ARM64 > + * procedure calling convention: the first paramter is passed in r0/x0, "parameter" > + * the second in r1/x1, the third in r2/x2 and the fourth in r3/x3. > + * Considering that Xen hypercalls have 5 arguments at most, the fifth > + * paramter is always passed in r4/x4, differently from the ARM > + * procedure calling convention of using the stack for that case. and "parameter" again. Strictly speaking the fifth argument handling only differs from the 32-bit PCS, not the 64-bit one. Splitting hairs a bit there. If you fix the typo and clarify the fifth argument or not as you wish: Acked-by: Ian Campbell <ian.campb...@citrix.com> Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/