Am Montag, 3. Juni 2013, 22:15:45 schrieb Heiko Stübner:
> Am Montag, 3. Juni 2013, 22:07:22 schrieb Mike Turquette:
> > Quoting Heiko Stübner (2013-06-03 12:33:19)
> >
> > > Hi Mike,
> > >
> > > I think it's a multiplexEr clock in the patch title, and see below
> >
> > Doh, you are right. But "xor" is so much cooler looking than "xer"...
> >
> > > Am Montag, 3. Juni 2013, 19:53:09 schrieb Mike Turquette:
> > > > Device Tree binding for the basic clock multiplexor, plus the setup
> > > > function to register the clock. Based on the existing fixed-clock
> > > > binding.
> > > >
> > > > Also relocate declaration of of_fixed_factor_clk_setup to keep things
> > > > tidy.
> > > >
> > > > Signed-off-by: Mike Turquette <mturque...@linaro.org>
> > >
> > > [...]
> > >
> > > > +
> > > > + reg = of_iomap(node, 0);
> > > > + pr_err("%s: reg is 0x%p\n", __func__, reg);
> > > > +
> > > > + if (of_property_read_u32(node, "mask", &mask)) {
> > > > + pr_err("%s: missing mask property for %s\n", __func__,
> > > > node->name); + return;
> > > > + }
> > > > +
> > > > + if (of_property_read_u32(node, "shift", &shift))
> > > > + pr_debug("%s: missing shift property defaults to zero
> > > > for %s\n", + __func__, node->name);
> > > > +
> > > > + if (of_property_read_bool(node, "index_one"))
> > > > + clk_mux_flags |= CLK_MUX_INDEX_ONE;
> > > > +
> > > > + clk = clk_register_mux_table(NULL, clk_name, parent_names,
> > > > num_parents, + 0, reg, 0, mask, clk_mux_flags,
> > > >
> > > ^- should probably be shift
> > >
> > > Otherwise looks cool and I'm currently trying it with my Rockchip code.
> >
> > Right again. My test platform seems to not shift the mask at all so
> > this did not cause a visible bug for me.
>
> I'm currently converting my rockchip stuff to it, as it would solve a lot
> of problems with the numerous clock types I'm defining just to put the
> shift and mask values somewhere.
>
> So lets see if anything more turns up ;-)
yep ... of_mux_clk_setup is quite talkative ... there are quite some (debug-?)
pr_errs in it ;-)
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
