On Mon, 2013-06-03 at 18:42 +0530, Viresh Kumar wrote: > On 3 June 2013 17:55, Andy Shevchenko <andriy.shevche...@linux.intel.com> > wrote:
> > In patch 2/2 I collect platform related code. I see a lot of #ifdefs > > related to OF and ACPI. I would like to split it further and create > > files like of.c and acpi.c. What do you think? > > Naahh.. OF by itself doesn't mean anything here on this driver. It > belongs to all the users that are using DT to enumerate it (Mostly > ARM). And they are going to use platform_driver interface. So, > code is well located currently too.. I got it. > ACPI, I am not sure.. you need these routines in your pci stuff too? No, ACPI is alike OF, it relies on platform driver. > Keep it this way: > - Keep all the common stuff across pci and platform in core.c > - everything else in pci and platform files. It seems it's kept in that way already. Thanks for your comments! I will resend patch series v1 w/o RFC and with PCI driver later (when it will be ready). I will attach the missed patch to the series in case Vinod doesn't apply it in time. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
