On 05/30/2013 11:40 AM, Cody P Schafer wrote: > Instead of leaving a hidden trap for the next person who comes along and > wants to add something to mem_section, add a big fat warning about it > needing to be a power-of-2, and insert a BUILD_BUG_ON() in sparse_init() > to catch mistakes. > > Right now non-power-of-2 mem_sections cause a number of WARNs at boot > (which don't clearly point to the size of mem_section as an issue), but > the system limps on (temporarily, at least). > > This is based upon Dave Hansen's earlier RFC where he ran into the same > issue: > "sparsemem: fix boot when SECTIONS_PER_ROOT is not power-of-2" > http://lkml.indiana.edu/hypermail/linux/kernel/1205.2/03077.html
Thanks for doing that, Cody. At the risk of patting myself on the back: Acked-by: Dave Hansen <dave.han...@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/