Marcell GAL wrote:
> 
> int pppoe_backlog_rcv(struct sock *sk, struct sk_buff *skb)
> {
>         lock_sock(sk);
>         pppoe_rcv_core(sk, skb);
>         release_sock(sk);
>         return 0;
> }
> 

The backlog_rcv() method is called inside local_bh_disable()
and so cannot call lock_sock().   Definitely a bug in pppoe.

It looks like pppoe_backlog_rcv() should be using bh_lock_sock().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to