On Thu, 16 May 2013 10:51:49 +0300 Dan Carpenter <dan.carpen...@oracle.com> wrote:
> "chunk_size" is an unsigned int and "pos" is an unsigned long. The > "& ~(chunk_size-1)" operation clears the high 32 bits unintentionally. > > The ALIGN() macro does the correct thing. > > ... > > @@ -95,7 +95,7 @@ static int minix_readdir(struct file * filp, void * dirent, > filldir_t filldir) > char *name; > __u32 inumber; > > - pos = (pos + chunk_size-1) & ~(chunk_size-1); > + pos = ALIGN(pos, chunk_size); > if (pos >= inode->i_size) > goto done; > I'm suspecting there aren't many minix filesystems out there with a >4G directory ;) But we should fix it to set a good example, and to quieten whatever-tool-i-suspect-you-were-using(?). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
