On Wed, May 22, 2013 at 08:32:20AM +0100, Chen Gang wrote: > On 05/22/2013 08:45 AM, Chen Gang wrote: > > On 05/21/2013 09:17 PM, Catalin Marinas wrote: > >> On Mon, May 20, 2013 at 05:19:31AM +0100, Chen Gang wrote: > >>> > >>> Need add the default file in 'asm/Kbuild' just like arm has done. > >>> > >>> The build command is: > >>> make EXTRA_CFLAGS=-W ARCH=arm64 allmodconfig > >>> make EXTRA_CFLAGS=-W ARCH=arm64 menuconfig > >>> set "aarch64-linux-gnu-" as cross compiling prefix. > >>> make EXTRA_CFLAGS=-W ARCH=arm64 > >>> > >>> The related error: > >>> drivers/parport/parport_pc.c:67:25: fatal error: asm/parport.h: No such > >>> file or directory > >> > >> As I don't see when we'd need this driver, you can probably change the > >> Kconfig entry (similar to the VGA_CONSOLE one). > >> > > After check the Kconfig in drivers, we can find quite a few using long > list args which related with ARCH. > > And they are not only depend on ARCHs, but also depend on another > things (e.g. VGA_CONSOL also depend on !4xx && !8xx, and another > combinations).
Given this dependency is on the negation of that symbol, you just remove it and have a "depends on HAVE_VGA_CONSOLE". The few architectures that need it will have to define it (X86, ARM with a few configurations). > We also can find another long list for depend on, but not related with > ARCH. > > They seems not quit difficult for reading (in fact, if we separate them > into pieces and let them spread into another areas, the reader will not > see the whole dependency clearly) > > For fixing bug, better as local as possible, as independent as possible, > it will be OK if only add !ARM64 for PARPORT_PC depend on, and it has > no any negative effect. But if we define CONFIG_HAVE_*, we have to let > it related with multiple platforms. > > For design: if can bear current design, better not to touch it, I think > current design is still sustainable, and not complex for understanding, > so not need redesign. We usually clean some of these as we hit them, otherwise people forget about the clean-up later ;). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
