On Fri, May 24, 2013 at 9:37 AM, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > On Wed, May 22, 2013 at 05:12:24PM -0500, Kent Yoder wrote: >> On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk >> <konrad.w...@oracle.com> wrote: >> > On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote: >> >> >> + notify_remote_via_evtchn(priv->evtchn); >> >> >> + >> >> >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); >> >> > >> >> > Um, + 6? Why? Is there an #define for that magic constant? >> >> > Should this value be read before you do the wait_for_tpm_stat stuff? >> >> >> >> This is hardcoded to 6 even in tpm.c. Time for a #define... >> >> >> >> > Otherwise it looks OK to me. Should this go through me or Kent? >> >> > And if so, is Kent waiting for my feedback? >> >> >> >> My comments were minor -- I was expecting feedback on your earlier >> >> comments before merging. I think this should go through the tpmdd >> >> maintainer if its going to live in drivers/char/tpm though. >> > >> > That is you I thought? >> > >> > konrad@phenom:~/mm$ scripts/get_maintainer.pl -f drivers/char/tpm >> > Kent Yoder <k...@linux.vnet.ibm.com> (maintainer:TPM DEVICE DRIVER) >> > Rajiv Andrade <m...@srajiv.net> (maintainer:TPM DEVICE DRIVER) >> > Marcel Selhorst <tp...@selhorst.net> (maintainer:TPM DEVICE DRIVER) >> > Sirrix AG <tp...@sirrix.com> (maintainer:TPM DEVICE DRIVER) >> > tpmdd-de...@lists.sourceforge.net (moderated list:TPM DEVICE DRIVER) >> > linux-kernel@vger.kernel.org (open list) >> >> That was me until today. :-) But I didn't see the response your comments >> yet. > > Congratulations to you on a move to a new job!! Can you say what it is?
Thanks, yeah I'm headed to Cisco -- the job will focus on pen testing and some security research. Kent > I am sure Daniel will post a patch shortly, and will CC everybody that > get_maintainer.pl > finds. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
