On Tue, May 21, 2013 at 02:54:00PM +0100, Ben Hutchings wrote: > On Tue, 2013-05-21 at 09:33 -0400, Neil Horman wrote: > > On Tue, May 21, 2013 at 01:42:56AM +0100, Ben Hutchings wrote: > > > Somewhat surprisingly, the net_dropmonitor reporting script doesn't work > > > at all. This series fixes it and then makes it slightly more efficient. > > > > > > Ben. > > > > > It worked fine when I first submitted it. I wonder if there was a paramter > > order change at some point that I wasn't CC'ed on. > > The parameter order for the trace event changed in 2.6.39, but that was > before this script went in. > > Ben. > Yeah, thats how this happened. I posted right before 2.6.39, which was around July 4th: https://lkml.org/lkml/2011/7/4/273
So I posted it, and shortly thereafter the perf infrastructure changed. Acme didnt actually pull the patch in until Well into August, and so it was borked from there. I never noticed as I had been using the netlink based utility since that time. Thanks for catching this! Neil > > Either way, this all looks good. Thanks Ben. > > > > Acked-by: Neil Horman <nhor...@tuxdriver.com> > > > > > Ben Hutchings (5): > > > perf: net_dropmonitor: Fix trace parameter order > > > perf: net_dropmonitor: Fix symbol-relative addresses > > > perf: net_dropmonitor: Do not assume ordering of dictionaries > > > perf: net_dropmonitor: Use bisection in symbol lookup > > > perf: net_dropmonitor: Remove progress indicator > > > > > > tools/perf/scripts/python/net_dropmonitor.py | 39 > > > ++++++++++++++------------ > > > 1 file changed, 21 insertions(+), 18 deletions(-) > > > > > > > > > > > > -- > Ben Hutchings > friends: People who know you well, but like you anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
