On Thu, May 16, 2013 at 3:58 PM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > Hello. > > > On 03/01/2013 05:02 PM, Rob Herring wrote: > >>>>>>> Fix the following compilation warnings (in Simon Horman's >>>>>>> renesas.git repo): >>>>>>> In file included from arch/arm/mach-shmobile/setup-r8a7779.c:24:0: >>>>>>> include/linux/of_platform.h:107:13: warning: ‘struct of_device_id’ >>>>>>> declared >>>>>>> inside parameter list [enabled by default] >>>>>>> include/linux/of_platform.h:107:13: warning: its scope is only this >>>>>>> definition >>>>>>> or declaration, which is probably not what you want [enabled by >>>>>>> default] >>>>>>> include/linux/of_platform.h:107:13: warning: ‘struct device_node’ >>>>>>> declared >>>>>>> inside parameter list [enabled by default] >>>>>>> <linux/of_platform.h> only #include's headers with definitions of >>>>>>> the above >>>>>>> mentioned structures if CONFIG_OF_DEVICE=y but uses them even if >>>>>>> not. One >>>>>>> solution is to move some #include's out of #ifdef CONFIG_OF_DEVICE >>>>>>> and use >>>>>>> incomplete declarations for the rest of the structures where the >>>>>>> #ifdef move >>>>>>> doesn't help... >>>>>>> Reported-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> >>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> >>>>>> >>>>>> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> >>>>>> Grant, could you consider taking this patch? >>>>> >>>>> Yes, I can, but I don't seem to have the original patch. Can you send >>>>> it >>>>> again. >>>> >>>> Nevermind. Found it. I'll apply it. >>> >>> Will you drop 'struct device_node' declaration then or should I >>> resend? In fact, I think I should better resend it with the changelog >>> somewhat edited. >> >> No, I plan to leave it as is and not rely on device.h by chance >> declaring device_node. > > > I hoped to see this fix in 3.10-rc1. Is there any hope to see it in > 3.10-rc's? > The code it fixes the warnings in is already in Linus tree.
So I had this queued up, but Grant did not send DT update to Linus for 3.10. The main thing we had was the preprocessor support and that went thru arm-soc tree. I plan to send this and other fixes to Linus for 3.10. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
