Hi Joseph, Thank you for the patch.
On Wednesday 15 May 2013 16:38:48 joseph.salisb...@canonical.com wrote: > From: Joseph Salisbury <joseph.salisb...@canonical.com> > > BugLink: http://bugs.launchpad.net/bugs/1180409 > > OminiVision webcam 0x05a9:0x2643 needs the same UVC_QUIRK_PROBE_DEF as other > OmniVision models to work properly. > > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mche...@redhat.com> > Cc: linux-me...@vger.kernel.org > Cc: sta...@vger.kernel.org > Signed-off-by: Joseph Salisbury <joseph.salisb...@canonical.com> There's already a 05a9:2643 webcam model, found in a Dell monitor, that has been reported to work properly without the UVC_QUIRK_PROBE_DEF. Enabling the quirk shouldn't hurt, but I'd like to check differences between the two devices. Could you please send me the output of lsusb -v -d 05a9:2643 (running as root if possible) ? > --- > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c > b/drivers/media/usb/uvc/uvc_driver.c index 5dbefa6..411682c 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2163,6 +2163,15 @@ static struct usb_device_id uvc_ids[] = { > .bInterfaceSubClass = 1, > .bInterfaceProtocol = 0, > .driver_info = UVC_QUIRK_PROBE_DEF }, > + /* Alienware X51*/ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x05a9, > + .idProduct = 0x2643, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_QUIRK_PROBE_DEF }, Your mailer messed up formatting. As the patch is small I've fixed it manually, but please make sure to use a proper mail client next time. I advise using git-send-email to send patches. > /* Apple Built-In iSight */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > > | USB_DEVICE_ID_MATCH_INT_INFO, -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
