Hello. On 05/13, Oleg Nesterov wrote: > > With the patch below we can trivially fix the problem, > > + char *fmt = ispipe ? "\e%s\e" : "%s"; > ... > - err = cn_printf(cn, "%s", current->comm); > + err = cn_printf(cn, fmt, current->comm); > > Or this ESC hack is too ugly or can break something?
OK, nobody really nacked "[PATCH] teach argv_split() to ignore the spaces surrounded by \e", see http://marc.info/?l=linux-kernel&m=136845597401674 I am going to send this patch "officially" and fix format_corename/argv_split interaction. But lets fix other format_corename() bugs first: leak and use-after-free. Plus some cleanups. Oleg. fs/coredump.c | 120 +++++++++++++++++++++++++++----------------------------- 1 files changed, 58 insertions(+), 62 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
