On 05/14/2013 09:45 AM, Cody P Schafer wrote:
Using Page*() triggers a camelcase warning, but shouldn't.
Introduced by be987d9f80354e2e919926349282facd74992f90, which added the
other Page flag users.
Pipe ('|') at the end of a grouping doesn't cause the grouping to match
an emtpy string, use ? after the grouping instead to get the desired
behavior.
Signed-off-by: Cody P Schafer <c...@linux.vnet.ibm.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..ee24026 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/
&&
+ $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/
&&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
Nix this, appears to still be broken
WARNING: Avoid CamelCase: <PageBuddy>
#51: FILE: mm/page_alloc.c:449:
+ VM_BUG_ON(!PageBuddy(page));
total: 0 errors, 1 warnings, 46 lines checked
/home/cody/mm/0008-page_alloc-add-return_pages_to_zone-when-DYNAMIC_NUM.patch
has style problems, please review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
